<html>
<head><meta charset="utf-8"><title>Good issue for compiler newbie · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html">Good issue for compiler newbie</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="197794501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/197794501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mikhail Rakhmanov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#197794501">(May 16 2020 at 12:55)</a>:</h4>
<p>Hey! I really want to get into compilers and rust-analyzer in general as recently I started actively writing in Rust. What issue should I choose as my first one provided that I don't have a lot of experience in compilers? Should I take any with the label "Good first issue"? Or maybe you have something specific which would be better for a newcomer?</p>



<a name="197795022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/197795022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#197795022">(May 16 2020 at 13:08)</a>:</h4>
<p>Hi! Maybe also look over E-easy and E-has-instructions</p>



<a name="197795030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/197795030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#197795030">(May 16 2020 at 13:09)</a>:</h4>
<p><a href="https://github.com/rust-analyzer/rust-analyzer/issues/4468">https://github.com/rust-analyzer/rust-analyzer/issues/4468</a> might be approachable, too</p>



<a name="197797206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/197797206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mikhail Rakhmanov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#197797206">(May 16 2020 at 14:05)</a>:</h4>
<p><span class="user-mention silent" data-user-id="203546">Laurențiu Nicola</span> <a href="#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Good.20issue.20for.20compiler.20newbie/near/197795030">said</a>:</p>
<blockquote>
<p><a href="https://github.com/rust-analyzer/rust-analyzer/issues/4468">https://github.com/rust-analyzer/rust-analyzer/issues/4468</a> might be approachable, too</p>
</blockquote>
<p>Cool, thanks! Looking at IntelliJ implementation right now, just for reference leaving links to relevant PRs here - <a href="https://github.com/intellij-rust/intellij-rust/pull/5182">https://github.com/intellij-rust/intellij-rust/pull/5182</a> (although not sure if it is helpful, still not very familiar with rust-analyzer, but will be looking into that) and the changelog where it was introduced (<a href="https://intellij-rust.github.io/2020/04/27/changelog-121.html">https://intellij-rust.github.io/2020/04/27/changelog-121.html</a>).<br>
By the way if I decide to work on something - should I mention that I started somewhere, or just create a PR as soon as it is done?</p>



<a name="197797829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/197797829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#197797829">(May 16 2020 at 14:21)</a>:</h4>
<p>You can leave a comment so that others won't start working on the same issue</p>



<a name="198492064"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/198492064" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mikhail Rakhmanov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#198492064">(May 22 2020 at 20:36)</a>:</h4>
<p><span class="user-mention" data-user-id="203546">@Laurențiu Nicola</span>  Hi! It seems I implemented most of the functionality. Can you please look and suggest what can I improve? Thanks! <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4576">https://github.com/rust-analyzer/rust-analyzer/pull/4576</a></p>



<a name="198525357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/198525357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#198525357">(May 23 2020 at 08:36)</a>:</h4>
<p>I only skimmed it, but there's a couple of <code>unwrap()</code>s that might end up crashing. We've had a lot of panics in assists in the past, partly because of the less-than-obvious thing that rust-analyzer tries to work with incomplete syntax trees (files with parse errors).</p>



<a name="198526643"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/198526643" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mikhail Rakhmanov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#198526643">(May 23 2020 at 09:14)</a>:</h4>
<p>Ok will check all unwraps and see if I can get rid of them</p>



<a name="198527939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/198527939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mikhail Rakhmanov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#198527939">(May 23 2020 at 09:53)</a>:</h4>
<p>Removed most of the unwraps</p>



<a name="198577500"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/198577500" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mikhail Rakhmanov <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#198577500">(May 24 2020 at 10:45)</a>:</h4>
<p>Btw can you pls tell me what is left to finalize the PR? Thanks!</p>



<a name="198577916"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/198577916" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#198577916">(May 24 2020 at 10:57)</a>:</h4>
<p>I think it looks fine, but I'm not the best person to review it.</p>



<a name="203111442"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/203111442" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chetan Khilosiya <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#203111442">(Jul 07 2020 at 14:43)</a>:</h4>
<p>Hi All, Can anyone please point me what is needed in this ticket <a href="https://github.com/rust-analyzer/rust-analyzer/issues/3813">https://github.com/rust-analyzer/rust-analyzer/issues/3813</a>. I can help complete the ticket.</p>



<a name="203111571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/203111571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#203111571">(Jul 07 2020 at 14:44)</a>:</h4>
<p>I think that actually should be fixed by <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4615">https://github.com/rust-analyzer/rust-analyzer/pull/4615</a></p>



<a name="203111622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/203111622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#203111622">(Jul 07 2020 at 14:44)</a>:</h4>
<p>it might be good to check if all looks good now, and close the issue then.</p>



<a name="203112339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/203112339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chetan Khilosiya <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#203112339">(Jul 07 2020 at 14:50)</a>:</h4>
<p>Ok, I will look if that ticket is fixed.</p>



<a name="203128918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/203128918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chetan Khilosiya <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#203128918">(Jul 07 2020 at 16:48)</a>:</h4>
<p>I verified that the issue is fixed properly. <a href="/user_uploads/4715/6LNSbQ6yUas1XLpuidADzF14/rust-hover-fix.png">rust-hover-fix.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/6LNSbQ6yUas1XLpuidADzF14/rust-hover-fix.png" title="rust-hover-fix.png"><img src="/user_uploads/4715/6LNSbQ6yUas1XLpuidADzF14/rust-hover-fix.png"></a></div>



<a name="203128969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/203128969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#203128969">(Jul 07 2020 at 16:49)</a>:</h4>
<p>Thanks <span class="user-mention" data-user-id="307521">@Chetan Khilosiya</span> !</p>



<a name="203129023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Good%20issue%20for%20compiler%20newbie/near/203129023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Chetan Khilosiya <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Good.20issue.20for.20compiler.20newbie.html#203129023">(Jul 07 2020 at 16:49)</a>:</h4>
<p>The hover popup respects font size either.<br>
Tested on latest master branch. And updated the ticket also.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>